Fix the distinction between missing and empty username/password for RFC3986 URIs #20335
+110
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You requested the 8.5 RMs. Should this target PHP-8.5 instead? In any case, I don't think their review is necessary, since this is a bugfix. |
|
Yes: I was in a hurry and I forgot to set the target |
kocsismate
requested review from
DanielEScherzer,
Girgias,
NattyNarwhal,
SakiTakamachi,
adoy,
alexdowad,
arnaud-lb,
bukka,
derickr,
devnexen,
dstogov,
kamil-tekiela,
youkidearitai and
zeriyoshi
as code owners
|
Ahh not even the base branch was right... I'll fix it later today |
kocsismate
force-pushed
the
ext-uri-userinfo-empty-fix
branch
from
628386f to
43dc427
Compare
kocsismate
requested review from
edorian
and removed request for
NattyNarwhal,
SakiTakamachi,
adoy,
alexdowad,
derickr,
devnexen,
kamil-tekiela,
youkidearitai and
zeriyoshi
ndossche
approved these changes
Oct 30, 2025
edorian
approved these changes
Oct 31, 2025
There was a problem hiding this comment.
RM approval from me. Please also wait for @DanielEScherzer 's review, as we're late in the release process
TimWolla
approved these changes
Oct 31, 2025
As mentioned before, I consider this a bugfix (and thus not need RM approval). And given that #20303 is already merged, merging this one for the same release would make sense. Don't forget to adjust NEWS. |
kocsismate
force-pushed
the
ext-uri-userinfo-empty-fix
branch
from
43dc427 to
cdf06e5
Compare
kocsismate
added a commit
that referenced
this pull request
Nov 2, 2025
* PHP-8.5: Fix the distinction between missing and empty username/password for RFC3986 URIs (#20335)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same way as #20303